feat: append nomad task mounts

[ttys3]

something like this: https://github.com/hashicorp/waypoint/blob/566c65afb74fcfe64f3f0e50ef7eddbd03d9a3c8/internal/serverinstall/nomad.go#L914

will always fail when using the podman driver, because the driver does not handle this mounts now.

this PR fixup it

[hashicorp-cla]

All committers have signed the CLA.

[ttys3]

@lgfa29 can you review this ?

[lgfa29]

Thanks for the PR @ttys3, and sorry for the delay and getting it reviewed.

I did a quick test using host volumes and it all seems to work 🙂

Would you mind adding some tests and a CHANGELOG entry?

[ttys3]

@lgfa29 updated. PTAL

tested, this does support https://www.nomadproject.io/docs/job-specification/volume_mount

resolve #146

nomad client host volume config:

client {
  enabled = true

  host_volume "waypoint-server" {
    path = "/var/lib/waypoint"
    read_only = false
  }
}

the job file: volume-mount-demo.nomad

job "docs" {
  datacenters = ["dc1"]

  group "example" {
    volume "my-vol" {
      type      = "host"
      read_only = true
      source    = "waypoint-server"
    }

    task "example" {
      driver = "podman"

      config {
        image = "alpine"

        command = "sleep"
        args    = ["3600"]
      }

      volume_mount {
        volume      = "my-vol"
        destination = "/demo/certs"
      }
    }
  }
}

[lgfa29]

Ah sorry, I mean like automated testing 😅

Something like this one, to verify that the configuration is properly set in the driver:
https://github.com/hashicorp/nomad-driver-podman/blob/v0.3.0/driver_test.go#L1225-L1232

You may need to update the client.hcl example config file to add a host volume:
https://github.com/hashicorp/nomad-driver-podman/blob/main/examples/nomad/client.hcl

[ttys3]

Ok, I'll figure a way to write some test.

[lgfa29]

Ok, I'll figure a way to write some test.

Thanks! I linked to an example, but let me know if you need more help.

[lgfa29]

Oh shoot, I forgot about this PR and ended up merging #169, which does the same thing. I'm going to close this one but credit you in the CHANGELOG entry as well.

Sorry for that @ttys3 😞

[ttys3]

@lgfa29 sorry for the huge delayed unit testing.

I checked the code, almost the same.

but what wondering me is that, I remember what block this PR is missing unit testing.

but I did not see any tests code in #169

[lgfa29]

Yeah, I wasn't paying enough attention when reviewing #169 😕

Did you happen to find a way to test this?