config: Add ulimit option like docker driver #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloyoyoista
force-pushed
the
ulimits
branch
3 times, most recently
from
72741cb
to
15342b4
Compare
pabloyoyoista
requested review from
jazzyfresh,
jrasell,
lgfa29 and
towe75
as code owners
|
This is just a small feature addition which makes this driver slightly closer to docker :) Hopefully it is uncontroversial. |
|
@towe75 @lgfa29 @jrasell @jazzyfresh friendly ping? :) |
lgfa29
approved these changes
May 30, 2022
There was a problem hiding this comment.
Sorry for the delay on getting this reviewed @pabloyoyoista.
This LGTM, I just pushed a commit to fix the CHANGELOG and add a link to the PR.
Also, this is kind of annoying, but would you mind opening a PR against the Nomad repo to also document the new config in this page:
https://github.com/hashicorp/nomad/blob/main/website/content/plugins/drivers/podman.mdx
Thanks for the contribution!
pabloyoyoista
added a commit
to pabloyoyoista/nomad
that referenced
this pull request
May 31, 2022
pabloyoyoista
added a commit
to pabloyoyoista/nomad
that referenced
this pull request
May 31, 2022
|
Thank you for the merge! Not fun to duplicate work, but just sent the docs update: hashicorp/nomad#13180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess the title is self-explanatory.
The
sliceMergeUlimitfunction is adapted from the nomad docker driver