Stream logs via podman api #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed sleeps from tests
towe75
added a commit
to pascomnet/nomad-driver-podman
that referenced
this pull request
Jun 2, 2021
…gger Add disable_log_collection driver option. Add more documentation to logger options.
|
@jrasell this is a somewhat long living branch but it's in a good shape now. Please review it. |
|
@towe75 just as a reminder, would you also update the |
|
Website docs updated in hashicorp/nomad#11300. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now we where only able to forward a combined stdout/stderr stream directly from the container to the alloc fifo. This imposes problems for external log shippers and also in situations where you depend on a separate stderr output.
This PR adds a podman API based log streamer to the plugin. It needs an extra opt-in by driver config and is, for now, restricted to the podman journald mode. It addresses also a discussion back from #4