fix: update incorrect DriverNetworkManager interface implementation i…

…n plugins/drivers/client.go and drivers/mock/driver.go And add assertions to catch drifts at compilation time.
hashicorp · Mar 15, 2022 · 4c9f476 · 4c9f476
1 parent dfd0bee
commit 4c9f476
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/drivers/mock/driver.go b/drivers/mock/driver.go
@@ -670,8 +670,10 @@ func (d *Driver) GetHandle(taskID string) *taskHandle {
 	return h
 }
 
-func (d *Driver) CreateNetwork(allocID string) (*drivers.NetworkIsolationSpec, error) {
-	return nil, nil
+var _ drivers.DriverNetworkManager = (*Driver)(nil)
+
+func (d *Driver) CreateNetwork(allocID string, request *drivers.NetworkCreateRequest) (*drivers.NetworkIsolationSpec, bool, error) {
+	return nil, true, nil
 }
 
 func (d *Driver) DestroyNetwork(allocID string, spec *drivers.NetworkIsolationSpec) error {

diff --git a/plugins/drivers/client.go b/plugins/drivers/client.go
@@ -468,7 +468,9 @@ func (d *driverPluginClient) ExecTaskStreamingRaw(ctx context.Context,
 	}
 }
 
-func (d *driverPluginClient) CreateNetwork(allocID string) (*NetworkIsolationSpec, bool, error) {
+var _ DriverNetworkManager = (*driverPluginClient)(nil)
+
+func (d *driverPluginClient) CreateNetwork(allocID string, _ *NetworkCreateRequest) (*NetworkIsolationSpec, bool, error) {
 	req := &proto.CreateNetworkRequest{
 		AllocId: allocID,
 	}