Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomad eval list command #11675

Merged
merged 8 commits into from
Dec 15, 2021
Merged

nomad eval list command #11675

merged 8 commits into from
Dec 15, 2021

Conversation

tgross
Copy link
Member

@tgross tgross commented Dec 14, 2021

Use the new filtering and pagination capabilities of the Eval.List RPC (ref #11648) to provide filtering and pagination at the command line.

Use the new filtering and pagination capabilities of the `Eval.List`
RPC to provide filtering and pagination at the command line.
Also includes note that `nomad eval status -json` is deprecated and
will be replaced with a single evaluation view in a future version of
Nomad.
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but looks great!

(also missing a changelog entry)

command/eval_list.go Outdated Show resolved Hide resolved
command/eval_list.go Outdated Show resolved Hide resolved
command/eval_list.go Outdated Show resolved Hide resolved
command/eval_list.go Outdated Show resolved Hide resolved
website/content/docs/commands/eval/list.mdx Outdated Show resolved Hide resolved
command/eval_list.go Outdated Show resolved Hide resolved
command/eval_list.go Outdated Show resolved Hide resolved
command/eval_list.go Show resolved Hide resolved
Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
command/eval_list.go Outdated Show resolved Hide resolved
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a comment on an edge case for displaying the -per-page help message, which seems like a quick fix so not a blocker. ✅ on this, good one!

@vercel vercel bot temporarily deployed to Preview – nomad December 15, 2021 16:31 Inactive
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants