Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: snapshot list pagination parameters #12193

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Conversation

tgross
Copy link
Member

@tgross tgross commented Mar 4, 2022

The snapshot list API supports pagination as part of the CSI
specification, but we didn't have it plumbed through to the command
line.

This also breaks E2E testing because the output from the AWS EBS plugin
can be extremely long without pagination, bringing the time it takes to
complete the command above the test timeout.


This PR requires bugfixes in #12194 #12195 and #12197, and currently includes those commits. It'll be rebased once those get merged.

The snapshot list API supports pagination as part of the CSI
specification, but we didn't have it plumbed through to the command
line.
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants