Using retracted version v1.1.5 of hashicorp/go-msgpack

[IamTheFij]

Nomad version

master

Operating system and Environment details

n/a

Issue

The current version listed in go.mod is a retracted version, v1.1.5. Apparently version v2.0.0 is identical and should be used instead. This prevents updating to new versions of github.com/hashicorp/nomad in other projects (such as github.com/hashicorp/terraform-provider-nomad

Reproduction steps

Check go.mod file for github.com/hashicorp/go-msgpack v1.1.5

Expected Result

Find github.com/hashicorp/go-msgpack v2.0.0 in go.mod

Actual Result

Find github.com/hashicorp/go-msgpack v1.1.5 in go.mod

Job file (if appropriate)

Nomad Server logs (if appropriate)

Nomad Client logs (if appropriate)

[lgfa29]

Reopening the issue because this upgrade causes Nomad to fail (#17047)

[tgross]

Adding to the mystery on this one, in hashicorp/raft#575 (comment) @banks pointed out that it should be safe to upgrade so long as you're using the old time encoding. But as it turns out, the code suggests that we think already are (ref structs.go#L12468-L12485):

// msgpackHandle is a shared handle for encoding/decoding of structs
var MsgpackHandle = func() *codec.MsgpackHandle {
	h := &codec.MsgpackHandle{}
	h.RawToString = true

	// maintain binary format from time prior to upgrading latest ugorji
	h.BasicHandle.TimeNotBuiltin = true

	// Sets the default type for decoding a map into a nil interface{}.
	// This is necessary in particular because we store the driver configs as a
	// nil interface{}.
	h.MapType = reflect.TypeOf(map[string]interface{}(nil))

	// only review struct codec tags
	h.TypeInfos = codec.NewTypeInfos([]string{"codec"})

	return h
}()

That handle gets used everywhere in our RPC transport. That suggests to me that we may have misconfigured the transport for Raft specifically. I haven't hunted that down yet but that feels like a clue if anyone else on the Nomad team finds themselves with time to dig into it.