[ui] Color indicators for server/client status #18318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Test Audit comparison
|
|
Maybe put the leader icon after the text so the text stays aligned? |
philrenaud
requested review from
angrycub
and removed request for
Juanadelacuesta
|
@apollo13 good call; I've moved it to post-text. |
|
So I generally appreciate color's ability to improve scanability and quite like this. Is it possible to provide a symbolic alternative to benefit folks that might not be able to use the colors? I think that Apple has a nice idea on this front with their "Differentiate without Color" accessibility option. h/t to AbilityNet's article How to differentiate items without using colour in iOS 15 on your iPhone, iPad, or iPod Touch |
|
@angrycub Thanks to your feedback on this, @juliezzhou and I went over and updated these to use icons where distinction is relevant, using Helios badges:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus a nice little icon for when a server is leader