Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consul Upstream Admin Partition Support #19785

Closed
mmcquillan opened this issue Jan 19, 2024 · 0 comments · Fixed by #20167
Closed

Consul Upstream Admin Partition Support #19785

mmcquillan opened this issue Jan 19, 2024 · 0 comments · Fixed by #20167
Assignees
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul type/enhancement
Milestone

Comments

@mmcquillan
Copy link
Collaborator

mmcquillan commented Jan 19, 2024

Proposal

Nomad does not expose destination_partition in the Consul SM upstreams block as of 1.7.2. We should do so.


As a possible workaround, has anyone successfully tested/used the service-defaults config entry to override the upstream definition? I’m thinking something like:

consul config write - <<EOF
Kind = "service-defaults"
Name = "dummy"
Partition = "gamma"
Namespace = "default"
UpstreamConfig = {
  Overrides = {
    Name = "counting"
    Partition = "default"
    Namespace = "default"
  }
}
# nomad job spec snippet
    ...
    service {
      name = "dummy"
      port = "9002"

      connect {
        sidecar_service {
          proxy {
            upstreams {
              destination_name = "counting"
              local_bind_port  = 8080
            }
          }
        }
      }
    }
@lgfa29 lgfa29 added the stage/accepted Confirmed, and intend to work on. No timeline committment though. label Feb 5, 2024
@tgross tgross self-assigned this Mar 20, 2024
tgross added a commit that referenced this issue Mar 20, 2024
Adds support for specifying a destination Consul admin partition in the
`upstream` block.

Fixes: #19785
tgross added a commit that referenced this issue Mar 20, 2024
Adds support for specifying a destination Consul admin partition in the
`upstream` block.

Fixes: #19785
@tgross tgross added this to the 1.7.x milestone Mar 20, 2024
tgross added a commit that referenced this issue Mar 20, 2024
Adds support for specifying a destination Consul admin partition in the
`upstream` block.

Fixes: #19785
tgross added a commit that referenced this issue Mar 22, 2024
…20167)

Adds support for specifying a destination Consul admin partition in the
`upstream` block.

Fixes: #19785
philrenaud pushed a commit that referenced this issue Apr 18, 2024
…20167)

Adds support for specifying a destination Consul admin partition in the
`upstream` block.

Fixes: #19785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul type/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants