Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase maximum ACL token length #3888

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Increase maximum ACL token length #3888

merged 2 commits into from
Mar 22, 2018

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Feb 20, 2018

This mitigates issues when generating Nomad ACL tokens from Vault.

Fixes #3879

This mitigates issues when generating Nomad ACL tokens from Vault.
@burdandrei
Copy link
Contributor

@dadgar isn't it logical to leave name max size 64 chars, and all the other info to write to description?

Copy link
Contributor

@preetapan preetapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase for changelog, otherwise LGTM

@dadgar dadgar merged commit 7d8ca3f into master Mar 22, 2018
@dadgar dadgar deleted the b-acl-name branch March 22, 2018 21:51
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants