Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous use of "filtered" #4471

Closed
iconara opened this issue Jul 5, 2018 · 2 comments
Closed

Ambiguous use of "filtered" #4471

iconara opened this issue Jul 5, 2018 · 2 comments

Comments

@iconara
Copy link
Contributor

iconara commented Jul 5, 2018

When I query an evaluation, or a job, that has not been possible to place I get a list that uses the word "filtered" ambiguously.

For example

Placement Failure
Task Group "foo":
  * Class "class1" filtered 1 nodes
  * Class "class2" filtered 3 nodes
  * Class "class3" filtered 1 nodes
  * Constraint "${meta.role} = role1" filtered 5 nodes

I can't tell whether or not "filtered" in this list means "selected" or "rejected". I assume "rejected" because I can kind of figure that out from the last list entry and my knowledge about the context, but at the same time, in most programming languages, including Go, that have a function called something like "filter" it means "select", so that's what I think when I read the list.

Would you consider changing the wording in this listing to be less ambiguous? I suggest using "rejected".

@preetapan
Copy link
Contributor

@iconara thanks for the suggestion. While I can see how generally filter can mean both "filter out" and "filter only", in this specific case the intent is "filtered out" and hopefully known from the rest of the sentence. It is listing specific constraints and showing how many nodes did not meet the constraint.

We could perhaps change it to "filtered out" to make it clearer.

@lgfa29
Copy link
Contributor

lgfa29 commented Feb 3, 2023

Closed by #7369

@lgfa29 lgfa29 closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants