Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaner output on not-applicable values for node-status #616

Closed
calvn opened this issue Dec 21, 2015 · 3 comments
Closed

Cleaner output on not-applicable values for node-status #616

calvn opened this issue Dec 21, 2015 · 3 comments

Comments

@calvn
Copy link
Member

calvn commented Dec 21, 2015

nomad nodes-status [node] should return a better formatted output if values are not found or not-applicable.

For example, if the AWS instance running the client does not contain a public IP it currently returns:

$ nomad node-status [node]
ID         = 27b007ac-6271-f166-f2c1-9e16be923e6e
Name       = 0baca28c8653
...
Attributes = 
...
platform.aws.public-hostname:<?xml version="1.0" encoding="iso-8859-1"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
         "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
  <title>404 - Not Found</title>
 </head>
 <body>
  <h1>404 - Not Found</h1>
 </body>
</html>, platform.aws.public-ipv4:<?xml version="1.0" encoding="iso-8859-1"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
         "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
  <title>404 - Not Found</title>
 </head>
 <body>
  <h1>404 - Not Found</h1>
 </body>
</html>
...

The output could be much cleaner if it showed platform.aws.public-hostname:n/a and platform.aws.public-ipv4:n/a instead, and same for any applicable fields that can't fetch a valid value.
@dadgar
Copy link
Contributor

dadgar commented Dec 21, 2015

duplicate of #611

@dadgar dadgar closed this as completed Dec 21, 2015
@calvn
Copy link
Member Author

calvn commented Dec 21, 2015

@dadgar damn you're quick. I thought something was wrong with me/my browser when it didn't show under open issues.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dadgar @calvn