Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default/Validate resources. #739

Merged
merged 4 commits into from
Feb 2, 2016
Merged

Default/Validate resources. #739

merged 4 commits into from
Feb 2, 2016

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Feb 2, 2016

This PR adds validation to the resources and default the CPU/Mem/Disk/IOPS resources.

@@ -619,6 +619,10 @@ func parseResources(result *structs.Resources, list *ast.ObjectList) error {
result.Networks = []*structs.NetworkResource{&r}
}

// Combine the parsed resources with a default resource block.
min := structs.DefaultResources()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this logic should be in the jobs endpoint? Users who are submitting the jobs via the http API can optionally get the default resources if they don't specify

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked about defaulting with Armon a bit and the consensus is the api endpoint should do as little defaulting as possible

dadgar added a commit that referenced this pull request Feb 2, 2016
@dadgar dadgar merged commit a7cdc6a into master Feb 2, 2016
@dadgar dadgar deleted the f-min-resources branch February 2, 2016 22:11
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants