Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove deprecated client options parameters docs #12416

Merged
merged 1 commit into from
Mar 31, 2022
Merged

docs: remove deprecated client options parameters docs #12416

merged 1 commit into from
Mar 31, 2022

Conversation

tgross
Copy link
Member

@tgross tgross commented Mar 31, 2022

The client configuration options for drivers have been deprecated
since 0.9. We haven't torn them out completely but because they're
deprecated it's been hard to guarantee correct behavior. Remove the
documentation so that users aren't misled about their viability.

Closes #12030

@tgross
docs: remove deprecated client options parameters docs
e426b0e 
The client configuration options for drivers have been deprecated
since 0.9. We haven't torn them out completely but because they're
deprecated it's been hard to guarantee correct behavior. Remove the
documentation so that users aren't misled about their viability.
@tgross tgross requested review from lgfa29 and shoenig March 31, 2022 14:47
@tgross tgross added theme/docs Documentation issues and enhancements backport/website This will backport PR changes to `stable-website` && the latest release-branch backport/1.1 labels Mar 31, 2022
shoenig
shoenig approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@tgross tgross mentioned this pull request Mar 31, 2022
Open
@tgross
Copy link
Member Author

tgross commented Mar 31, 2022

I've opened #12420 for removing the deprecated config itself.

@tgross tgross merged commit 6668ce0 into main Mar 31, 2022
@tgross tgross deleted the docs-remove-deprecated-client-options branch March 31, 2022 15:45
This was referenced Mar 31, 2022
Merged
Merged
@lgfa29 lgfa29 added backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line labels Apr 19, 2022
This was referenced Apr 19, 2022
Merged
Closed
lgfa29 pushed a commit that referenced this pull request Apr 19, 2022
@tgross @lgfa29
docs: remove deprecated client options parameters docs (#12416)
a2ecaab 
The client configuration options for drivers have been deprecated
since 0.9. We haven't torn them out completely but because they're
deprecated it's been hard to guarantee correct behavior. Remove the
documentation so that users aren't misled about their viability.
tgross added a commit that referenced this pull request Sep 29, 2022
@tgross
Revert removing deprecated client options docs
494796d 
This reverts PR #12416 and commit 6668ce0.

While the driver options are well and truly deprecated, this documentation also
covers features like `fingerprint.denylist` that are not available any other
way. Let's revert this until #12420 is ready.
@tgross tgross mentioned this pull request Sep 29, 2022
Merged
tgross added a commit that referenced this pull request Sep 30, 2022
@tgross
Revert removing deprecated client options docs (#14753)
fb1f5ea 
This reverts PR #12416 and commit 6668ce0.

While the driver options are well and truly deprecated, this documentation also
covers features like `fingerprint.denylist` that are not available any other
way. Let's revert this until #12420 is ready.
This was referenced Sep 30, 2022
Merged
Merged
Merged
Merged
tgross added a commit that referenced this pull request Sep 30, 2022
@tgross
Revert removing deprecated client options docs (#14753)
4202f9c 
This reverts PR #12416 and commit 6668ce0.

While the driver options are well and truly deprecated, this documentation also
covers features like `fingerprint.denylist` that are not available any other
way. Let's revert this until #12420 is ready.
tgross added a commit that referenced this pull request Sep 30, 2022
@hc-github-team-nomad-core @tgross
Revert removing deprecated client options docs (#14753) (#14755)
175915f 
This reverts PR #12416 and commit 6668ce0.

While the driver options are well and truly deprecated, this documentation also
covers features like `fingerprint.denylist` that are not available any other
way. Let's revert this until #12420 is ready.

Co-authored-by: Tim Gross <tgross@hashicorp.com>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoenig shoenig shoenig approved these changes

@lgfa29 lgfa29 Awaiting requested review from lgfa29

Assignees
No one assigned
Labels
backport/website This will backport PR changes to `stable-website` && the latest release-branch backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line theme/docs Documentation issues and enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to turn off gc of docker images or set image_delay to anything longer than 3m
3 participants
@tgross @shoenig @lgfa29