Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add -core suffix to mods action #15015

Merged
merged 1 commit into from
Oct 24, 2022
Merged

ci: add -core suffix to mods action #15015

merged 1 commit into from
Oct 24, 2022

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Oct 21, 2022

Forgot to add this line to the new mods job; without it, it
creates a cache different from the one used by the other jobs. 🤦

Forgot to add this line to the new mods action; without it, it
creates a cache different from the one used by the other jobs.
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shoenig shoenig merged commit 4ffb8c0 into main Oct 24, 2022
@shoenig shoenig deleted the ci-fix-mods-cache-key branch October 24, 2022 13:49
shoenig added a commit that referenced this pull request Oct 27, 2022
Forgot to add this line to the new mods action; without it, it
creates a cache different from the one used by the other jobs.
shoenig added a commit that referenced this pull request Oct 27, 2022
* ci: use the same go mod cache across test-core jobs (#15006)

* ci: use the same go mod cache for test-core jobs

* ci: precache go modules

* ci: add a mods precache job

* ci: add -core suffix to mods action (#15015)

Forgot to add this line to the new mods action; without it, it
creates a cache different from the one used by the other jobs.

* ci: use groups of tests in gha (#15018)

* [no ci] use json for grouping packages for testing

* [no ci] able to get packages in group

* [no ci] able to run groups of tests

* [no ci] more

* [no ci] try disable circle unit tests

* ci: use actions/checkout@v3

* ci: rename to quick

* ci: need make dev in mods cache step

* ci: make compile step depend on checks step

* ci: bump consul and vault versions

* ci: need make dev for group tests

* ci: update ci unit testing docs

* docs: spell plumbing correctly

Co-authored-by: Tim Gross <tgross@hashicorp.com>

Co-authored-by: Tim Gross <tgross@hashicorp.com>

* deps: run go mod tidy

Co-authored-by: Tim Gross <tgross@hashicorp.com>
shoenig added a commit that referenced this pull request Oct 27, 2022
* ci: use the same go mod cache across test-core jobs (#15006)

* ci: use the same go mod cache for test-core jobs

* ci: precache go modules

* ci: add a mods precache job

* ci: add -core suffix to mods action (#15015)

Forgot to add this line to the new mods action; without it, it
creates a cache different from the one used by the other jobs.

* ci: use groups of tests in gha (#15018)

* [no ci] use json for grouping packages for testing

* [no ci] able to get packages in group

* [no ci] able to run groups of tests

* [no ci] more

* [no ci] try disable circle unit tests

* ci: use actions/checkout@v3

* ci: rename to quick

* ci: need make dev in mods cache step

* ci: make compile step depend on checks step

* ci: bump consul and vault versions

* ci: need make dev for group tests

* ci: update ci unit testing docs

* docs: spell plumbing correctly

Co-authored-by: Tim Gross <tgross@hashicorp.com>

Co-authored-by: Tim Gross <tgross@hashicorp.com>

* deps: run go mod tidy

Co-authored-by: Tim Gross <tgross@hashicorp.com>
shoenig added a commit that referenced this pull request Nov 3, 2022
* ci: backport of gha groups  (#15058)

* ci: use the same go mod cache across test-core jobs (#15006)

* ci: use the same go mod cache for test-core jobs

* ci: precache go modules

* ci: add a mods precache job

* ci: add -core suffix to mods action (#15015)

Forgot to add this line to the new mods action; without it, it
creates a cache different from the one used by the other jobs.

* ci: use groups of tests in gha (#15018)

* [no ci] use json for grouping packages for testing

* [no ci] able to get packages in group

* [no ci] able to run groups of tests

* [no ci] more

* [no ci] try disable circle unit tests

* ci: use actions/checkout@v3

* ci: rename to quick

* ci: need make dev in mods cache step

* ci: make compile step depend on checks step

* ci: bump consul and vault versions

* ci: need make dev for group tests

* ci: update ci unit testing docs

* docs: spell plumbing correctly

Co-authored-by: Tim Gross <tgross@hashicorp.com>

Co-authored-by: Tim Gross <tgross@hashicorp.com>

* deps: run go mod tidy

Co-authored-by: Tim Gross <tgross@hashicorp.com>

* build: fix makefile conflict

Co-authored-by: Tim Gross <tgross@hashicorp.com>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants