-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add -core suffix to mods action #15015
Conversation
Forgot to add this line to the new mods action; without it, it creates a cache different from the one used by the other jobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Forgot to add this line to the new mods action; without it, it creates a cache different from the one used by the other jobs.
* ci: use the same go mod cache across test-core jobs (#15006) * ci: use the same go mod cache for test-core jobs * ci: precache go modules * ci: add a mods precache job * ci: add -core suffix to mods action (#15015) Forgot to add this line to the new mods action; without it, it creates a cache different from the one used by the other jobs. * ci: use groups of tests in gha (#15018) * [no ci] use json for grouping packages for testing * [no ci] able to get packages in group * [no ci] able to run groups of tests * [no ci] more * [no ci] try disable circle unit tests * ci: use actions/checkout@v3 * ci: rename to quick * ci: need make dev in mods cache step * ci: make compile step depend on checks step * ci: bump consul and vault versions * ci: need make dev for group tests * ci: update ci unit testing docs * docs: spell plumbing correctly Co-authored-by: Tim Gross <tgross@hashicorp.com> Co-authored-by: Tim Gross <tgross@hashicorp.com> * deps: run go mod tidy Co-authored-by: Tim Gross <tgross@hashicorp.com>
* ci: use the same go mod cache across test-core jobs (#15006) * ci: use the same go mod cache for test-core jobs * ci: precache go modules * ci: add a mods precache job * ci: add -core suffix to mods action (#15015) Forgot to add this line to the new mods action; without it, it creates a cache different from the one used by the other jobs. * ci: use groups of tests in gha (#15018) * [no ci] use json for grouping packages for testing * [no ci] able to get packages in group * [no ci] able to run groups of tests * [no ci] more * [no ci] try disable circle unit tests * ci: use actions/checkout@v3 * ci: rename to quick * ci: need make dev in mods cache step * ci: make compile step depend on checks step * ci: bump consul and vault versions * ci: need make dev for group tests * ci: update ci unit testing docs * docs: spell plumbing correctly Co-authored-by: Tim Gross <tgross@hashicorp.com> Co-authored-by: Tim Gross <tgross@hashicorp.com> * deps: run go mod tidy Co-authored-by: Tim Gross <tgross@hashicorp.com>
* ci: backport of gha groups (#15058) * ci: use the same go mod cache across test-core jobs (#15006) * ci: use the same go mod cache for test-core jobs * ci: precache go modules * ci: add a mods precache job * ci: add -core suffix to mods action (#15015) Forgot to add this line to the new mods action; without it, it creates a cache different from the one used by the other jobs. * ci: use groups of tests in gha (#15018) * [no ci] use json for grouping packages for testing * [no ci] able to get packages in group * [no ci] able to run groups of tests * [no ci] more * [no ci] try disable circle unit tests * ci: use actions/checkout@v3 * ci: rename to quick * ci: need make dev in mods cache step * ci: make compile step depend on checks step * ci: bump consul and vault versions * ci: need make dev for group tests * ci: update ci unit testing docs * docs: spell plumbing correctly Co-authored-by: Tim Gross <tgross@hashicorp.com> Co-authored-by: Tim Gross <tgross@hashicorp.com> * deps: run go mod tidy Co-authored-by: Tim Gross <tgross@hashicorp.com> * build: fix makefile conflict Co-authored-by: Tim Gross <tgross@hashicorp.com>
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Forgot to add this line to the new mods job; without it, it
creates a cache different from the one used by the other jobs. 🤦