[ui, compliance] Remove the newline after .hbs copyright headers

[philrenaud]

We were seeing test failures in main related to log-content equivalence tests, as well as some flakey percy vertical spacing issues, that seem to point to the newline after copyright headers. This PR attempts to remove that newline across all our .hbs files in the ui, to see if those problems are resolved.

[github-actions]

Ember Asset Size action

As of e1ef6df

Files that got Smaller 🎉:

File	raw	gzip
nomad-ui.js	-2.33 kB	-42 B

Files that stayed the same size 🤷‍:

File	raw	gzip
vendor.js	0 B	0 B
nomad-ui.css	0 B	0 B
vendor.css	0 B	0 B

[github-actions]

Ember Test Audit comparison

	main	e1ef6df	change
passes	1482	1489	+7
failures	7	0	-7
flaky	0	0	0
duration	000ms	11m 01s 706ms	+11m 01s 706ms

[lgfa29]

Have you tested with ~}} for white-space control? I'm afraid that without fixing the bot we will keep running into this problem and having to manually fix new files.

[tgross]

I'm afraid that without fixing the bot we will keep running into this problem and having to manually fix new files.

It looks like we can run copywrite locally to see if it'll fail these files again.

[tgross]

LGTM but worth verifying it won't get undone by the bot again

[philrenaud]

~}}

@lgfa29 very pleased to report that the ~}} style syntax works exactly the same as removing the newline altogether!

[lgfa29]

Great! Looking at copywrite source code it seems like it only checks for the license information, not the exact comment structure, so it won't try to change these files.

But I think it would be worth a PR to update .hbs headers to look like this and avoid the unnecessary line break. This will ensure new files are correct from the beginning.

I can take care of opening the PR, unless you really want to 😄