[ui, deployments] Denominator based on completed allocations for batch jobs #17147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Asset Size actionAs of 18364f4 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
philrenaud
force-pushed
the
17139-running-allocations-denominator-for-batch-jobs-should-combine-all-non-complete-allocs
branch
from
18364f4
to
53fc47f
Compare
ChaiWithJai
approved these changes
May 11, 2023
philrenaud
deleted the
17139-running-allocations-denominator-for-batch-jobs-should-combine-all-non-complete-allocs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't count "complete" allocations against the denominator in the "7/10 Allocations Running" heading, when the 3 non-running are of "complete" status. Instead, in this case, we would say "7/7 Remaining Allocations Running".
Resolves #17139