Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: write js doc #17156

Merged
merged 2 commits into from
May 11, 2023
Merged

chore: write js doc #17156

merged 2 commits into from
May 11, 2023

Conversation

ChaiWithJai
Copy link
Contributor

Closes #17141

@github-actions
Copy link

Ember Asset Size action

As of 9b1870f

Files that stayed the same size 🤷‍:

File raw gzip
nomad-ui.js 0 B 0 B
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

Ember Test Audit comparison

main 9b1870f change
passes 1495 1495 0
failures 4 4 0
flaky 0 0 0
duration 000ms 000ms -000ms

@ChaiWithJai ChaiWithJai merged commit ca00af7 into main May 11, 2023
5 checks passed
@ChaiWithJai ChaiWithJai deleted the 17141/js-doc branch May 11, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philrenaud philrenaud philrenaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui] Add JS Doc for JobEditor and JobsJobDefinition Route and Controler.
2 participants
@ChaiWithJai @philrenaud