[ui, deployments] Deployment history on steady state #17167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
force-pushed
the
17159-ui-steady-state-task-events
branch
from
67e7ab3
to
3d2cf93
Compare
Ember Asset Size actionAs of c90694d Files that got Bigger 🚨:
Files that got Smaller 🎉:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
ChaiWithJai
approved these changes
May 12, 2023
| export default class JobStatusDeploymentHistoryComponent extends Component { | ||
| @service notifications; | ||
|
|
||
| @tracked isHidden = this.args.isHidden; |
There was a problem hiding this comment.
note: If you ever invoke the component with the value of this argument as a variable instead of a hard coded boolean value, this property will not reactively update based on the value of that variable changing. Using a reactive getter will remove the possibility of a bug like this.
There was a problem hiding this comment.
@ChaiWithJai Yep, started with that, but my toggle would cease to work in this case. I could have an "in-between" variable to use for toggling but that felt like things would be getting out of sorts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a toggle to show/hide deployment history, and adds task event history to steady-state job status panels
Resolves #17159