Backport of [ui] Keyboard shortcuts to switch regions into release/1.5.x #17171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/17168-ui-keyboard-nav-allow-switching-between-regions/yearly-daring-ibex
branch
2 times, most recently
from
bc5daa3
to
8be5097
Compare
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 1 out of 2 committers have signed the CLA.
temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
Ember Test Audit comparison
|
philrenaud
deleted the
backport/17168-ui-keyboard-nav-allow-switching-between-regions/yearly-daring-ibex
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #17169 to be assessed for backporting due to the inclusion of the label backport/1.5.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Adds
r #keyboard bindings to regions.Note: I'm making an assumption here that users have few regions in general to save on keystrokes. If, however, we expect that users commonly have 10+ regions, then I should switch this to
r 0 1instead of justr 1, lest you end up on the wrong region when you meant to go to region 10 or 11 etc. (we evaluate the buffer on keypress eagerly)