[ui] Adds a "Scheduling" filter to the job.allocations page #17227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
commented
May 17, 2023
| @@ -48,7 +48,7 @@ | |||
| @condition={{not (eq type.label "unplaced")}} | |||
| @route="jobs.job.allocations" | |||
| @model={{@job}} | |||
| @query={{hash status=(concat '["' type.label '"]') version=(concat '[' (keys this.versions) ']')}} | |||
| @query={{hash status=(concat '["' type.label '"]') version=(concat '[' (map-by "version" this.versions) ']')}} | |||
There was a problem hiding this comment.
Noted that I was being inconsistent after changing my version sorting logic a few PRs ago.
Ember Asset Size actionAs of 8525f9d Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
ChaiWithJai
approved these changes
May 18, 2023
philrenaud
deleted the
17221-add-a-will-not-reschedule-filter-to-the-joballocations-page
branch
lgfa29
suggested changes
May 18, 2023
| @@ -326,6 +326,7 @@ func (a *Allocation) Stub() *AllocationListStub { | |||
| TaskStates: a.TaskStates, | |||
| DeploymentStatus: a.DeploymentStatus, | |||
| FollowupEvalID: a.FollowupEvalID, | |||
| NextAllocation: a.JobID, | |||
There was a problem hiding this comment.
Suggested change
| NextAllocation: a.JobID, | |
| NextAllocation: a.NextAllocation, |
Comment on lines
+17
to
+29
| @query={{hash scheduling=(concat '["has-been-rescheduled"]') version=(concat '[' @job.latestDeployment.versionNumber ']')}} | ||
| @label="View Allocations" | ||
| @class="failed-or-lost-link" | ||
| > | ||
| {{@allocs.length}} | ||
| </ConditionalLinkTo> | ||
| {{/if}} | ||
| {{#if (eq @title "Restarted")}} | ||
| <ConditionalLinkTo | ||
| @condition={{this.shouldLinkToAllocations}} | ||
| @route="jobs.job.allocations" | ||
| @model={{@job}} | ||
| @query={{hash scheduling=(concat '["has-been-restarted"]') version=(concat '[' @job.latestDeployment.versionNumber ']')}} |
There was a problem hiding this comment.
What is being concatened in (concat '["has-been-rescheduled"]') and (concat '["has-been-restarted"]')? It seems like it's just a string?
There was a problem hiding this comment.
Good catch; this was an artefact from earlier! Will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new filter, "Scheduling", to the job allocations page. This helps facilitate Rescheduled/Restarted links from the upcoming Job Status Panel and gives us future options for letting users drill down on this list page.
Because of some seen inconsistencies in testing, this adds
NextAllocationto Allocations in their list/stub form from our API, where before they only existed when an allocation was being fetched individually. This, combined with a check for FollowUpEvalID, gives us a better picture of "Is a terminal allocation never going to be rescheduled?", which the UI is seeking to show to users here.Resolves #17221