Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] A few variables-ui-related bugfixes #17319

Merged
merged 2 commits into from
May 25, 2023

Conversation

philrenaud
Copy link
Contributor

@philrenaud philrenaud commented May 25, 2023

  • Adds a "this variable will be accessible by all jobs" notification if saving to exactly nomad/jobs
  • moves said notification, on new variables, to the top of the form because otherwise it separated the "Add More" button and made it non-obviously connected
  • fixed a bug where a no-namespaces cluster would result in no duplicate path warnings firing
  • delete button is disabled for the only remaining KV in a variable when editing
  • fixed a bug where you would add an illegal character, delete the KV row, add a new blank one, and the illegal character warning was still present.

@github-actions
Copy link

github-actions bot commented May 25, 2023

Ember Test Audit comparison

main 41bae45 change
passes 1475 1475 0
failures 0 0 0
flaky 0 0 0
duration 13m 30s 519ms 13m 26s 238ms -04s 281ms

@philrenaud philrenaud force-pushed the ui-variable-job-info-notification branch from 0bb70f7 to 76d995e Compare May 25, 2023 19:58
@philrenaud philrenaud force-pushed the ui-variable-job-info-notification branch from 76d995e to 41bae45 Compare May 25, 2023 20:00
@philrenaud philrenaud added the backport/1.5.x backport to 1.5.x release line label May 25, 2023
@philrenaud philrenaud merged commit 087ac3a into main May 25, 2023
6 of 7 checks passed
@philrenaud philrenaud deleted the ui-variable-job-info-notification branch May 25, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.5.x backport to 1.5.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants