ui: node pools - add pool count to topology visualization #17363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Test Audit comparison
|
ChaiWithJai
force-pushed
the
17290/node-pools-topo-viz-view
branch
from
2ee0eb8
to
6c4524e
Compare
philrenaud
approved these changes
May 31, 2023
lgfa29
pushed a commit
that referenced
this pull request
Jun 21, 2023
* chore: create pool adapter * chore: mirage route handler * ui: add pool count to topo * ui: node pools data on `jobs.index` page (#17368) * ui: node filter on jobs.index * ui: add node pool to table viz * ui: node pools - client page visualization (#17372) * refact: update mirage models * ui: add pool filter to client list * ui: add pool to table viz * ui: add pool to statsboxes (#17373)
lgfa29
pushed a commit
that referenced
this pull request
Jun 21, 2023
* chore: create pool adapter * chore: mirage route handler * ui: add pool count to topo * ui: node pools data on `jobs.index` page (#17368) * ui: node filter on jobs.index * ui: add node pool to table viz * ui: node pools - client page visualization (#17372) * refact: update mirage models * ui: add pool filter to client list * ui: add pool to table viz * ui: add pool to statsboxes (#17373)
lgfa29
pushed a commit
that referenced
this pull request
Jun 22, 2023
* chore: create pool adapter * chore: mirage route handler * ui: add pool count to topo * ui: node pools data on `jobs.index` page (#17368) * ui: node filter on jobs.index * ui: add node pool to table viz * ui: node pools - client page visualization (#17372) * refact: update mirage models * ui: add pool filter to client list * ui: add pool to table viz * ui: add pool to statsboxes (#17373)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17290
This PR adds a new route handler in our Mirage config to handle node pool requests, it also creates an Adapter for Node Pools to handle the unique shape of the API endpoint where the
resourceis a first-level child of therelationalResourcein the anatomy of the endpoint. This PR also adds a count of total node pools to the topology visualization.Impact
This PR impacts our Mirage server (the fake calls we make), our Ember Adapter (the real API requests we make) and the Topology visualization.
Side Effect
The updates the
metricCSS class to use a Sass ampersand to create a more specific nestedmetric topoclass. We needed a quick way to add a visually appealing third column to the view without breaking the other views that rely on themetricclass.Next Steps
We will now add the appropriate node pool filter and table column to the Clients and Jobs List pages. And then the associated table detail within the Client and Job Detail Overview pages.