Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix changelog entry typo #17743

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix changelog entry typo #17743

merged 1 commit into from
Jun 27, 2023

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Jun 26, 2023

No description provided.

@shoenig shoenig requested review from lgfa29 and jrasell June 26, 2023 20:46
jrasell
jrasell approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Does the PR need any backport labels, so it gets fixed in the relevant release branches also?

@shoenig
Copy link
Member Author

shoenig commented Jun 27, 2023

I don't think so, or at least the original PR wasn't backported #16463

@luiz in case we're missing something

@shoenig shoenig merged commit 6b06b02 into main Jun 27, 2023
4 checks passed
@shoenig shoenig deleted the fix-type-changelog-16463 branch June 27, 2023 13:02
@lgfa29
Copy link
Contributor

lgfa29 commented Jul 4, 2023

That's right, #16463 was not backported. IIRC the reasoning was that this was more of a semantics issue that we want to correct, but it's not relevant enough to risk breaking existing release lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrasell jrasell jrasell approved these changes

@lgfa29 lgfa29 Awaiting requested review from lgfa29

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shoenig @lgfa29 @jrasell