Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul: handle "not found" errors from Consul when deleting tokens #17847

Merged
merged 1 commit into from
Jul 7, 2023
Merged

consul: handle "not found" errors from Consul when deleting tokens #17847

merged 1 commit into from
Jul 7, 2023

Commits on Jul 7, 2023

  1. consul: handle "not found" errors from Consul when deleting tokens 

    In Consul 1.15.0, the Delete Token API was changed so as to return an error when
deleting a non-existent ACL token. This means that if Nomad successfully deletes
the token but fails to persist that fact, it will get stuck trying to delete a
non-existent token forever.

Update the token deletion function to ignore "not found" errors and treat them
as successful deletions.

Fixes: #17833
    @tgross
    tgross committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    2dced0a View commit details
    Browse the repository at this point in the history