Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nomad Actions #18794

Merged
merged 8 commits into from
Oct 20, 2023
Merged

Nomad Actions #18794

merged 8 commits into from
Oct 20, 2023

Commits on Oct 18, 2023

  1. Scaffolding actions (#18639)

    * Task-level actions for job submissions and retrieval
    
    * FIXME: Temporary workaround to get ember dev server to pass exec through to 4646
    
    * Update api/tasks.go
    
    Co-authored-by: Tim Gross <tgross@hashicorp.com>
    
    * Update command/agent/job_endpoint.go
    
    Co-authored-by: Tim Gross <tgross@hashicorp.com>
    
    * Diff and copy implementations
    
    * Action structs get their own file, diff updates to behave like our other diffs
    
    * Test to observe actions changes in a version update
    
    * Tests migrated into structs/diff_test and modified with PR comments in mind
    
    * APIActionToSTructsAction now returns a new value
    
    * de-comment some plain parts, remove unused action lookup
    
    * unused param in action converter
    
    ---------
    
    Co-authored-by: Tim Gross <tgross@hashicorp.com>
    philrenaud and tgross committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    aeaa428 View commit details
    Browse the repository at this point in the history
  2. New endpoint: job/:id/actions (#18690)

    * unused param in action converter
    
    * backing out of parse_job level and moved toward new endpoint level
    
    * Adds taskName and taskGroupName to actions at job level
    
    * Unmodified job mock actions tests
    
    * actionless job test
    
    * actionless job test
    
    * Multi group multi task actions test
    
    * HTTP method check for GET, cleaner errors in job_endpoint_test
    
    * decomment
    philrenaud committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    d6c350a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3a931d1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    95923c0 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Run Action websocket endpoint (#18760)

    * Working demo for review purposes
    
    * removal of cors passthru for websockets
    
    * Remove job_endpoint-specific ws handlers and aimed at existing alloc exec handlers instead
    
    * PR comments adressed, no need for taskGroup pass, better group and task lookups from alloc
    
    * early return in action validate and removed jobid from req args per PR comments
    
    * todo removal, we're checking later in the rpc
    
    * boolean style change on tty
    philrenaud committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    ee99a02 View commit details
    Browse the repository at this point in the history
  2. Action CLI command (#18778)

    * Action command init and stuck-notes
    
    * Conditional reqpath to aim at Job action endpoint
    
    * De-logged
    
    * General CLI command cleanup, observe namespace, pass action as string, get random alloc w group adherence
    
    * tab and varname cleanup
    
    * Remove action param from Allocations().Exec calls
    philrenaud committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    195bfc4 View commit details
    Browse the repository at this point in the history
  3. changelog

    philrenaud committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    bde0d8c View commit details
    Browse the repository at this point in the history
  4. dont nil-check acl

    philrenaud committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    1fe0e11 View commit details
    Browse the repository at this point in the history