-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nomad Actions #18794
Merged
Merged
Nomad Actions #18794
Commits on Oct 18, 2023
-
* Task-level actions for job submissions and retrieval * FIXME: Temporary workaround to get ember dev server to pass exec through to 4646 * Update api/tasks.go Co-authored-by: Tim Gross <tgross@hashicorp.com> * Update command/agent/job_endpoint.go Co-authored-by: Tim Gross <tgross@hashicorp.com> * Diff and copy implementations * Action structs get their own file, diff updates to behave like our other diffs * Test to observe actions changes in a version update * Tests migrated into structs/diff_test and modified with PR comments in mind * APIActionToSTructsAction now returns a new value * de-comment some plain parts, remove unused action lookup * unused param in action converter --------- Co-authored-by: Tim Gross <tgross@hashicorp.com>
Configuration menu - View commit details
-
Copy full SHA for aeaa428 - Browse repository at this point
Copy the full SHA aeaa428View commit details -
New endpoint: job/:id/actions (#18690)
* unused param in action converter * backing out of parse_job level and moved toward new endpoint level * Adds taskName and taskGroupName to actions at job level * Unmodified job mock actions tests * actionless job test * actionless job test * Multi group multi task actions test * HTTP method check for GET, cleaner errors in job_endpoint_test * decomment
Configuration menu - View commit details
-
Copy full SHA for d6c350a - Browse repository at this point
Copy the full SHA d6c350aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a931d1 - Browse repository at this point
Copy the full SHA 3a931d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95923c0 - Browse repository at this point
Copy the full SHA 95923c0View commit details
Commits on Oct 20, 2023
-
Run Action websocket endpoint (#18760)
* Working demo for review purposes * removal of cors passthru for websockets * Remove job_endpoint-specific ws handlers and aimed at existing alloc exec handlers instead * PR comments adressed, no need for taskGroup pass, better group and task lookups from alloc * early return in action validate and removed jobid from req args per PR comments * todo removal, we're checking later in the rpc * boolean style change on tty
Configuration menu - View commit details
-
Copy full SHA for ee99a02 - Browse repository at this point
Copy the full SHA ee99a02View commit details -
* Action command init and stuck-notes * Conditional reqpath to aim at Job action endpoint * De-logged * General CLI command cleanup, observe namespace, pass action as string, get random alloc w group adherence * tab and varname cleanup * Remove action param from Allocations().Exec calls
Configuration menu - View commit details
-
Copy full SHA for 195bfc4 - Browse repository at this point
Copy the full SHA 195bfc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for bde0d8c - Browse repository at this point
Copy the full SHA bde0d8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fe0e11 - Browse repository at this point
Copy the full SHA 1fe0e11View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.