Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator debug: fix pprof interval handling #20206

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Commits on Mar 22, 2024

  1. operator debug: fix pprof interval handling

    The `nomad operator debug` command saves a CPU profile for each interval, and
    names these files based on the interval.
    
    The same functions takes a goroutine profile, heap profile, etc. but is missing
    the logic to interpolate the file name with the interval. This results in the
    operator debug command making potentially many expensive profile requests, and
    then overwriting the data. Update the command to save every profile it scrapes,
    and number them similarly to the existing CPU profile.
    
    Additionally, the command flags for `-pprof-interval` and `-pprof-duration` were
    validated backwards, which meant that we always coerced the `-pprof-interval` to
    be the same as the `-pprof-duration`, which always resulted in a single profile
    being taken at the start of the bundle. Correct the check as well as change the
    defaults to be more sensible.
    
    Fixes: #20151
    tgross committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    da335f5 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. changelog

    tgross committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    2c17720 View commit details
    Browse the repository at this point in the history