Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment watcher: fix goroutine leak when job is purged #20348

Merged
merged 2 commits into from
Apr 11, 2024

Commits on Apr 10, 2024

  1. deployment watcher: fix goroutine leak when job is purged

    The deployment watcher on the leader makes blocking queries to detect when the
    set of active deployments changes. It takes the resulting list of deployments
    and adds or removes watchers based on whether the deployment is active. But when
    a job is purged, the deployment will be deleted. This unblocks the query but
    the query result only shows the remaining deployments.
    
    When the query unblocks, ensure that all active watchers have a corresponding
    deployment in state. If not, remove the watcher so that the goroutine stops.
    
    Fixes: #19988
    tgross committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    004fb71 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Configuration menu
    Copy the full SHA
    bd2fbcc View commit details
    Browse the repository at this point in the history