Backport of [gh-6980] Client: clean up old allocs before running new ones using the exec task driver. into release/1.6.x
#20583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Juanadelacuesta
force-pushed
the
backport/gh-b-6980/evidently-sweeping-primate
branch
from
a53a241
to
7bbc5f7
Compare
Juanadelacuesta
force-pushed
the
backport/gh-b-6980/evidently-sweeping-primate
branch
from
7bbc5f7
to
f87c183
Compare
Juanadelacuesta
force-pushed
the
backport/gh-b-6980/evidently-sweeping-primate
branch
from
f87c183
to
a6d4c3a
Compare
…he `exec` task driver. (#20500) Whenever the "exec" task driver is being used, nomad runs a plug in that in time runs the task on a container under the hood. If by any circumstance the executor is killed, the task is reparented to the init service and wont be stopped by Nomad in case of a job updated or stop. This commit introduces two mechanisms to avoid this behaviour: * Adds signal catching and handling to the executor, so in case of a SIGTERM, the signal will also be passed on to the task. * Adds a pre start clean up of the processes in the container, ensuring only the ones the executor runs are present at any given time.
Juanadelacuesta
force-pushed
the
backport/gh-b-6980/evidently-sweeping-primate
branch
from
a6d4c3a
to
480d6b0
Compare
Juanadelacuesta
force-pushed
the
backport/gh-b-6980/evidently-sweeping-primate
branch
from
480d6b0
to
4df01ea
Compare
Juanadelacuesta
force-pushed
the
backport/gh-b-6980/evidently-sweeping-primate
branch
from
4df01ea
to
3563841
Compare
pkazmierczak
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20500 to be assessed for backporting due to the inclusion of the label backport/1.6.x.
🚨
The person who merged in the original PR is:
@Juanadelacuesta
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Whenever the "exec" task driver is being used, nomad runs a plug in that in time runs the task on a container under the hood. If by any circumstance the executor is killed, the task is reparented to the init service and wont be stopped by Nomad in case of a job updated or stop.
This PR introduces two mechanisms to avoid this behaviour:
It fixes #6980
Overview of commits