Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deps] Update hcl/v2 to latest patch v2.20.2-0.20240517235513-55d9c02d147d #22439

Merged
merged 1 commit into from
May 31, 2024
Merged

[deps] Update hcl/v2 to latest patch v2.20.2-0.20240517235513-55d9c02d147d #22439

merged 1 commit into from
May 31, 2024

Conversation

angrycub
Copy link
Contributor

@angrycub angrycub commented May 31, 2024 •
edited
Loading

Part of the foundational work for updating the Sentinel version

@angrycub angrycub marked this pull request as ready for review May 31, 2024 19:13
@angrycub angrycub requested review from tgross and shoenig May 31, 2024 19:13
tgross
tgross approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@tgross tgross left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (once CI is green)

We should backport this to all supported versions, just to make sure we can push any future HCL (or Sentinel) bug fixes into backports without hassle.

@angrycub angrycub self-assigned this May 31, 2024
@angrycub angrycub added backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.8.x backport to 1.8.x release line labels May 31, 2024
@angrycub angrycub merged commit 180bab8 into main May 31, 2024
35 of 37 checks passed
@angrycub angrycub deleted the deps/hcl2 branch May 31, 2024 19:42
This was referenced May 31, 2024
Closed
Closed
Merged
@angrycub angrycub restored the deps/hcl2 branch May 31, 2024 19:48
@angrycub angrycub added backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent and removed backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent labels May 31, 2024
@tgross tgross mentioned this pull request Jun 4, 2024
Closed
@ghthor ghthor mentioned this pull request Jun 5, 2024
Merged
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross tgross tgross approved these changes

@shoenig shoenig Awaiting requested review from shoenig

Assignees

@angrycub angrycub

Labels
backport/ent/1.6.x+ent Changes are backported to 1.6.x+ent backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/ent/1.8.x+ent Changes are backported to 1.8.x+ent backport/1.8.x backport to 1.8.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@angrycub @tgross