docs: Fix parameter type and default value in client reserved configuration. #23359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
liukch
changed the title
|
@tgross Would you willing to have a sit to review this PR. |
|
@liukch we've got a "community rotation" where someone is assigned to triage issues and PRs. It'll get picked up by them. |
tgross
approved these changes
Jun 21, 2024
tgross
added
backport/ent/1.6.x+ent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reserved cores parameter in Nomad client agent configuration is
inttype, and default value is0.But according to the source codes, it is
stringtype, and defalut value isempty string.This part of the document has bothered me for a long time, so I want to fix it.