Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Series of scheduler fixes / debugging enhancements #4720

Merged
merged 14 commits into from Sep 25, 2018
Merged

Series of scheduler fixes / debugging enhancements #4720

merged 14 commits into from Sep 25, 2018

Commits on Sep 21, 2018

  1. Fix deployment watcher index usage

    Fixes three issues:
    1. Retrieving the latest evaluation index was not properly selecting the
    greatest index. This would undermine checks we had to reduce the number
    of evaluations created when the latest eval index was greater than any
    alloc change
    2. Fix an issue where the blocking query code was using the incorrect
    index such that the index was higher than necassary.
    3. Special case handling of blocked evaluation since the create/snapshot
    index is no particularly useful since they can be reblocked.
    dadgar committed Sep 21, 2018
    Configuration menu
    Copy the full SHA
    34e8b2f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f782216 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2018

  1. Configuration menu
    Copy the full SHA
    9d4ff89 View commit details
    Browse the repository at this point in the history
  2. Denormalize jobs in plan and ignore resources of terminal allocs

    Denormalize jobs in AppendAllocs:
    AppendAlloc was originally only ever called for inplace upgrades and new
    allocations. Both these code paths would remove the job from the
    allocation. Now we use this to also add fields such as FollowupEvalID
    which did not normalize the job. This is only a performance enhancement.
    
    Ignore terminal allocs:
    Failed allocations are annotated with the followup Eval ID when one is
    created to replace the failed allocation. However, in the plan applier,
    when we check if allocations fit, these terminal allocations were not
    filtered. This could result in the plan being rejected if the node would
    be overcommited if the terminal allocations resources were considered.
    dadgar committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    82889c4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    06920ee View commit details
    Browse the repository at this point in the history
  4. test allocs fit

    dadgar committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    4c40d62 View commit details
    Browse the repository at this point in the history
  5. Unique TriggerBy for blocked evals

    Give blocked evals a unique triggerby reason to make debugging a chain
    of evaluations easier.
    dadgar committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    ed53038 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #4709 from hashicorp/b-deployments

    Fix deployment watcher index usage
    dadgar committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    b8ec297 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    302a694 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #4716 from hashicorp/f-no-reuse-triggerby

    Unique TriggerBy for blocked evals
    dadgar committed Sep 24, 2018
    Configuration menu
    Copy the full SHA
    029a7f6 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2018

  1. Configuration menu
    Copy the full SHA
    e9c7dc1 View commit details
    Browse the repository at this point in the history
  2. Add failed follow up to the list of allowed eval trigger reasons

    needs unit test
    preetapan authored and dadgar committed Sep 25, 2018
    Configuration menu
    Copy the full SHA
    47e22f6 View commit details
    Browse the repository at this point in the history
  3. fix logging

    dadgar committed Sep 25, 2018
    Configuration menu
    Copy the full SHA
    b3e8555 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #4712 from hashicorp/b-failed-trigger-reason

    Add a missing eval trigger reason
    dadgar committed Sep 25, 2018
    Configuration menu
    Copy the full SHA
    bcb1a67 View commit details
    Browse the repository at this point in the history