Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade hcl2 to validate arrays for unknown values #5844

Merged
merged 2 commits into from Jun 19, 2019
Merged

Upgrade hcl2 to validate arrays for unknown values #5844

merged 2 commits into from Jun 19, 2019

Commits on Jun 17, 2019

  1. Add a test for unknown variables

    Mahmood Ali committed Jun 17, 2019
    Copy the full SHA
    95adf61 View commit details
    Browse the repository at this point in the history

  2. Upgrade hcl2 to validate arrays for unknown values 

    This upgrades hcl2 library dependency to pick up
hashicorp/hcl2#113 .

Prior to this change, parsing and decoding array attributes containing
invalid errors (e.g. references to unknown variables) are silently
dropped, with `cty.Unknown` being assigned to the bad element.  Rather
than showing a type/meaningful error from hcl2, we get a very decrypted
error message from msgpack layer trying to handle `cty.unknown`.

This ensures that we propagate diagnostics correctly and report
meaningful errors to users.

Fixes #5694
Fixes #5680
    Mahmood Ali committed Jun 17, 2019
    Copy the full SHA
    9ebf0a7 View commit details
    Browse the repository at this point in the history