New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base podman e2e test and provisioning updates #8104
Conversation
5553c8a
to
508007d
Compare
Excludes setup for rootless podman. updates source ami to ubuntu 18.04 Installs podman and configures podman varlink base podman test ensure client status running revert terraform directory changes
508007d
to
c1fb05c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. I've left a couple of questions which you might have already answered for yourself during testing.
fyi the most recently built |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Upgrades base ami to ubuntu 18.04. Adds systemd units for podman and varlink, updates grub to allow cgroup memory and swap.
I ran into issues with port 53 on ubuntu 18.04, disabling systemd-resolved and using dnsmasq for forwarding to consul seemed like the path of least resistance but I am admittedly out of my comfort zone with those changes, happy to discuss alternatives.