Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base podman e2e test and provisioning updates #8104

Merged
merged 5 commits into from Jun 3, 2020
Merged

Conversation

drewbailey
Copy link
Contributor

@drewbailey drewbailey commented Jun 3, 2020

Upgrades base ami to ubuntu 18.04. Adds systemd units for podman and varlink, updates grub to allow cgroup memory and swap.

I ran into issues with port 53 on ubuntu 18.04, disabling systemd-resolved and using dnsmasq for forwarding to consul seemed like the path of least resistance but I am admittedly out of my comfort zone with those changes, happy to discuss alternatives.

Excludes setup for rootless podman. updates source ami to ubuntu 18.04
Installs podman and configures podman varlink

base podman test

ensure client status running

revert terraform directory changes
@drewbailey drewbailey requested a review from tgross June 3, 2020 17:03
@drewbailey drewbailey changed the title Podman/terraform base podman e2e test and provisioning updates Jun 3, 2020
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. I've left a couple of questions which you might have already answered for yourself during testing.

vendor/github.com/hashicorp/go-discover/go.mod Outdated Show resolved Hide resolved
e2e/terraform/shared/config/provision-client.sh Outdated Show resolved Hide resolved
e2e/terraform/packer/linux/setup.sh Outdated Show resolved Hide resolved
@drewbailey
Copy link
Contributor Author

fyi the most recently built e2e-nomad* ami is using this PR (wanted to test the pr feedback changes) and didn't prefix it with my name as I had been doing. will either leave it or rebuild the packer image on master at the end of the day

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@drewbailey drewbailey merged commit 40441df into master Jun 3, 2020
@drewbailey drewbailey deleted the podman/terraform branch June 3, 2020 18:07
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants