Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ansible docs to remove references to WinRMPassword #60

Merged
merged 1 commit into from
Jul 22, 2021
Merged

update ansible docs to remove references to WinRMPassword #60

merged 1 commit into from
Jul 22, 2021

Conversation

SwampDragons
Copy link
Contributor

WinRMPassword is deprecated in favor of ${build.Password} and {{build Password}}
Fixes #56

@SwampDragons SwampDragons requested a review from a team as a code owner July 12, 2021 17:41
nywilken
nywilken approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I'm not sure why the build failed. Looks like a possible upstream circle issue.

I'll leave the merge to you in case you want to deploy the docs to packer.io.

@nywilken nywilken merged commit 47cbb43 into main Jul 22, 2021
@nywilken nywilken deleted the update_docs branch July 22, 2021 13:24
@azr azr added the docs label Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

{{ .WinRMPassword }} is not interpolated
3 participants
@SwampDragons @nywilken @azr