Document lack of support for parallel docker login.
#143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbajolet-hashicorp
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Hi @huyz,
Thanks for taking the time to do this, the fix looks good to me, the docs should prevent the kind of gotcha you encountered earlier.
!
An extra whitespace was present at the beginning of a line in the filepath import for `driver_docker.go'. This made the linter complain, so we run goimports on the file to fix it.
|
FYI @huyz, there was a lint issue in one of the files, I pushed a commit on top of your branch to fix this. Once tests pass, I'll merge this in |
|
@lbajolet-hashicorp Oops, I don't know how I accidentally pushed that file. Thanks for fixing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the gotcha in #141
Replaces the closed PR #142