Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a leading slash to fix links #116

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

rkoron007
Copy link
Contributor

Adding a leading slash before "packer" to fix these the last two links on: https://developer.hashicorp.com/packer/integrations/hashicorp/hyperv

Adding a leading slash before "packer" to fix these the last two links on: https://developer.hashicorp.com/packer/integrations/hashicorp/hyperv
@rkoron007 rkoron007 requested a review from a team as a code owner November 3, 2023 21:54
@rkoron007
Copy link
Contributor Author

I'm not quite sure how to fix that failing check, I'd love some guidance if you have it!

Copy link
Member

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rkoron007 thanks for the fix. Documentation changes for all packer plugins requires an extra generation step to update the docs on DevDot. That step has been rolled into make generate which will sync all updates made to docs/ to the hidden .web-docs/ directory.

I went ahead and made the change to get this fix merged in.

@nywilken nywilken merged commit 263d753 into hashicorp:main Nov 6, 2023
7 of 8 checks passed
@nywilken nywilken added the documentation Improvements or additions to documentation label Nov 6, 2023
@nywilken
Copy link
Member

nywilken commented Nov 6, 2023

Once doc changes have been merged you can deploy the latest doc change to DevDot manually using the following action https://github.com/hashicorp/packer-plugin-hyperv/actions/workflows/notify-integration-release-via-manual.yaml

@rkoron007
Copy link
Contributor Author

Thank you for the help and the helpful background, Wilken! I took all this done in my notes, and will know what to do next time! 🧠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants