Address differences between iso and clone regarding disk creation.
#147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using proxmox-iso, calling SetVmConfig() for the EFI disk creates it twice, with the second disk being unused: unused0: local-zfs:vm-110-disk-1 Fix this by limiting the call to proxmox-clone.
sebastian-de
force-pushed
the
fix-efi
branch
2 times, most recently
from
0a2bc4b
to
51d97ec
Compare
lbajolet-hashicorp
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Hi @sebastian-de,
Just left a small suggestion regarding the regexp you defined to figure out which disks are unused, but aside from that LGTM!
| @@ -105,6 +99,17 @@ func (s *stepFinalizeTemplateConfig) Run(ctx context.Context, state multistep.St | |||
| } | |||
| } | |||
|
|
|||
| // Disks that get replaced by the builder end up as unused disks - | |||
| // find and remove them. | |||
| rxUnused := regexp.MustCompile(`^(unused)\d+`) | |||
There was a problem hiding this comment.
Unless you're using the regexp to extract things, I'd think the parentheses are not useful here
Handle disks that got replaced by the clone builder and end up unused.
|
Hey @lbajolet-hashicorp, |
|
My pleasure, thanks again for the effort you're pushing towards improving this plugin @sebastian-de, we really appreciate the involvement here, kudos to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
efi_configbrought differences betweenisoandcloneto light.The first difference is that
isowill create the EFI disk in the first run and the additional call ofSetVmConfigis not needed.The second one is that
clonewill replace disks that are already present on the cloned VM with the ones specified in the builder configuration.I addressed both differences in separate commits.
Closes #145