builder: call Comm.Prepare before resetting host #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A regression was introduced in the plugin in commit f65be3c, where the logic for detecting a missing host, and falling back to localhost used to work with SSH only, and was generalised through the `Host()' method to work with WinRM too. This logic however was flawed, as it required an explicit Type for the communicator to work. This is the case for winrm, but ssh being the default didn't need to, leading to the case where we resetted the host to 127.0.0.1. To prevent this, we ensure the Type is properly set, which is done in the `c.Comm.Prepare` function, from the packer SDK. This in turn makes `Host()` report the right host for implicit ssh connections, and not an empty one as previously would happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced in the plugin in commit f65be3c, where the logic for detecting a missing host, and falling back to localhost used to work with SSH only, and was generalised through the `Host()' method to work with WinRM too.
This logic however was flawed, as it required an explicit Type for the communicator to work. This is the case for winrm, but ssh being the default didn't need to, leading to the case where we resetted the host to 127.0.0.1.
To prevent this, we ensure the Type is properly set, which is done in the
c.Comm.Preparefunction, from the packer SDK. This in turn makesHost()report the right host for implicit ssh connections, and not an empty one as previously would happen.Closes: hashicorp/packer#11961