fix: configuration of additional disks

[LIV2]

Additional disks would always get configured as scsi devices regardless of disk_adapter_type.

This change ensures that additional disks are always configured on the same bus as the primary disk.

Closes #91

[dkierner-dh]

@tenthirtyam I would add the bug label instead of the enhancement label as it does not work as intended:

packer-plugin-vmware/docs-partials/builder/vmware/common/DiskConfig-not-required.mdx

Lines 3 to 17 in e67b91e

	- `disk_additional_size` ([]uint) - The size(s) of any additional
	hard disks for the VM in megabytes. If this is not specified then the VM
	will only contain a primary hard disk. The builder uses expandable, not
	fixed-size virtual hard disks, so the actual file representing the disk will
	not use the full size unless it is full.
	- `disk_adapter_type` (string) - The adapter type of the VMware virtual disk to create. This option is
	for advanced usage, modify only if you know what you're doing. Some of
	the options you can specify are `ide`, `sata`, `nvme` or `scsi` (which
	uses the "lsilogic" scsi interface by default). If you specify another
	option, Packer will assume that you're specifying a `scsi` interface of
	that specified type. For more information, please consult [Virtual Disk
	Manager User's Guide](http://www.vmware.com/pdf/VirtualDiskManager.pdf)
	for desktop VMware clients. For ESXi, refer to the proper ESXi
	documentation.

[dkierner-dh]

@tenthirtyam @nywilken Hi, is there anything in particular that blocks @LIV2's pull request #95 from being merged?
In contrast to #96 this is merely a bug fix and I would like to have that bug fixed with version 1.0.8.

[tenthirtyam]

Both will need thoughtful reviews and testing.

I'm happy to assist the maintainers with both once I'm back from sabbatical.

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

[nywilken]

Please give me time to pull this down and give it a test.

[nywilken]

@LIV2 thanks again for opening up this change. I apologies as I wasn't able to prioritize this review sooner. I reviewed and validated the fix. I am able to get VMware Fusion to build as expected with the disk using the SATA bus.

==> vmware-iso.debian: Deleting unnecessary VMware files...
    vmware-iso.debian: Deleting: builds/debian_aarch64/packer-debian.plist
    vmware-iso.debian: Deleting: builds/debian_aarch64/packer-debian.scoreboard
    vmware-iso.debian: Deleting: builds/debian_aarch64/vmware.log
==> vmware-iso.debian: Compacting all attached virtual disks...
    vmware-iso.debian: Compacting virtual disk 1
    vmware-iso.debian: Compacting virtual disk 2
    vmware-iso.debian: Compacting virtual disk 3
    vmware-iso.debian: Compacting virtual disk 4
==> vmware-iso.debian: Cleaning VMX prior to finishing up...
    vmware-iso.debian: Detaching ISO from CD-ROM device sata0:1...
    vmware-iso.debian: Disabling VNC server...
==> vmware-iso.debian: Skipping export of virtual machine...
Build 'vmware-iso.debian' finished after 5 minutes 42 seconds.

==> Wait completed after 5 minutes 42 seconds

==> Builds finished. The artifacts of successful builds are:
--> vmware-iso.debian: VM files in directory: builds/debian_aarch64