Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update clone/iso config #373

Merged
merged 1 commit into from
Mar 5, 2024
Merged

docs: update clone/iso config #373

merged 1 commit into from
Mar 5, 2024

Conversation

tenthirtyam
Copy link
Collaborator

Summary

Updates config documentation for vsphere-clone and vsphere-iso.

Testing

packer-plugin-vsphere on ξ‚  docs/update-clone-iso-config via 🐹 v1.22.0 
➜ make build

packer-plugin-vsphere on ξ‚  docs/update-clone-iso-config via 🐹 v1.22.0 took 3.4s 
➜ make generate
2024/03/04 21:59:25 Copying "docs" to ".docs/"
2024/03/04 21:59:25 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vsphere on ξ‚  docs/update-clone-iso-config via 🐹 v1.22.0 took 11.6s 
➜ make test
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        1.435s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       2.698s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       5.587s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  1.783s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   3.911s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       1.293s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      2.155s

@tenthirtyam
docs: update clone/iso config
55bc672 
Updates config documentation for `vsphere-clone` and `vsphere-iso`.

Signed-off-by: Ryan Johnson <ryantenthirtyam.org>
@tenthirtyam tenthirtyam added the documentation Improvements or additions to documentation label Mar 5, 2024
@tenthirtyam tenthirtyam self-assigned this Mar 5, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner March 5, 2024 03:00
nywilken
nywilken approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates. LGTM

@nywilken nywilken merged commit 350f684 into main Mar 5, 2024
12 checks passed
@nywilken nywilken deleted the docs/update-clone-iso-config branch March 5, 2024 23:35
@tenthirtyam tenthirtyam added this to the v1.2.5 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nywilken nywilken nywilken approved these changes

@lbajolet-hashicorp lbajolet-hashicorp Awaiting requested review from lbajolet-hashicorp

Assignees

@tenthirtyam tenthirtyam

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.2.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tenthirtyam @nywilken