Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade github.com/zclconf/go-cty to v1.11.1 #12055

Open
nywilken opened this issue Oct 18, 2022 · 2 comments
Open

Upgrade github.com/zclconf/go-cty to v1.11.1 #12055

nywilken opened this issue Oct 18, 2022 · 2 comments
Labels
breaking-change dependencies Auto-pinning sync to jira For issues that need to be imported to Packer internal JIRA backlog

Comments

@nywilken
Copy link
Member

Upgrade github.com/zclconf/go-cty to v1.11.1

In v1.11.0 go-cty dropped all encoding/gob support - refer to commit for details.
Gob support is currently being used by the Datasource RPC server, and possiblity within other locations, for communication with the data source plugin components. Before upgrading
to the latest go-cty version the RPC serialization code must be updated to use a new serialization format or we can look into copying the encoding/gob support into
the Packer SDK if there are no other options.
@nywilken nywilken added breaking-change dependencies Auto-pinning sync to jira For issues that need to be imported to Packer internal JIRA backlog labels Oct 18, 2022
@github-actions
Copy link

This issue has been synced to JIRA for planning.

JIRA ID: HPR-808

@nywilken nywilken mentioned this issue Oct 18, 2022
Closed
@nywilken
Copy link
Member Author

Related to hashicorp/packer-plugin-sdk#135

@nywilken nywilken added this to the 1.8.5 milestone Nov 4, 2022
@chris-rock chris-rock mentioned this issue Nov 21, 2022
Merged
3 tasks
chris-rock added a commit to mondoohq/packer-plugin-cnspec that referenced this issue Nov 30, 2022
@chris-rock @scottford-io
⭐️ use cnspec for policy execution (#48)
62bd615 
- update to go 1.19
- remove dependency on external mondoo binary 
- switch to use inventory instead of config piping to external binary

*cty dependency downgrade*

Packer and Terraform use different versions of go cty. The problem is
that packer does not work with the latest version of go-cty as
documented here:

- [hashicorp/packer-plugin-sdk incompatible with zclconf/go-cty v1.11.0
· Issue #134 · zclconf/go-cty ·
GitHub](zclconf/go-cty#134)
- [Upgrade github.com/zclconf/go-cty to v1.11.1 · Issue #12055 ·
hashicorp/packer ·
GitHub](hashicorp/packer#12055)
- [Upgrade github.com/zclconf/go-cty to v1.11.1 · Issue #135 ·
hashicorp/packer-plugin-sdk ·
GitHub](hashicorp/packer-plugin-sdk#135)

There are two issues, we cannot bundle both go-cty versions due to the
fact that it is not labeled a major change. Out only option to get this
working for now is to downgrade cty in cnquery and cnspec.

*TODOs*

- [x] downgrade cty in cnquery
mondoohq/cnquery#499
- [x] downgrade cty in cnspec
mondoohq/cnspec#201
- [x] update readme

Co-authored-by: Scott Ford <49754039+scottford-io@users.noreply.github.com>
@nywilken nywilken modified the milestones: 1.8.5, 1.8.6 Dec 1, 2022
This was referenced Dec 13, 2022
Closed
Closed
@chris-rock chris-rock mentioned this issue Dec 14, 2022
Closed
@nywilken nywilken removed this from the 1.8.6 milestone Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change dependencies Auto-pinning sync to jira For issues that need to be imported to Packer internal JIRA backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nywilken