add build.name to hcl code #10114
Merged
add build.name to hcl code #10114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
SwampDragons
force-pushed
the
build_name_hcl
branch
from
6ce745e
to
d895b0b
Compare
34 tasks
azr
reviewed
Oct 16, 2020
| }, | ||
| fileCheck: fileCheck{ | ||
| expected: []string{ | ||
| "pineapple.pizza.txt", |
azr
approved these changes
Oct 16, 2020
There was a problem hiding this comment.
Super good work ! The provisioner re-prepare probably made this a bit harder to dev as the value was overwritten !
If/when we go with an implementation where things are prepared only whey they are about to be launched (HCL2Core) then this will be a bit simpler 🙂 .
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build name and Source name are not the same thing in HCL -- while users can name builds, they previously had not way of accessing the buildname in variables. This adds a "name" key to the build accessor so that users can read out this var.
This checks off a box in #9176