Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use packer-sdc in packer + remove mapstructure-to-hcl2 & struct-markdown #10913

Merged
merged 7 commits into from
Apr 16, 2021

Conversation

azr
Copy link
Contributor

@azr azr commented Apr 16, 2021

This follows hashicorp/packer-plugin-sdk#53. This will be a breaking change for plugins that use go install .../hashicorp/packer/cmd/...@latest not when we merge this but when we release Packer because latest is the latest tagged version.

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #10913 (89beb20) into master (da312e2) will increase coverage by 0.80%.
The diff coverage is n/a.

Impacted Files Coverage Δ
builder/alicloud/ecs/access_config.go 20.42% <ø> (+1.61%) ⬆️
builder/alicloud/ecs/builder.go 13.63% <ø> (+0.22%) ⬆️
builder/alicloud/ecs/image_config.go 59.25% <ø> (+2.11%) ⬆️
builder/alicloud/ecs/run_config.go 86.95% <ø> (+0.28%) ⬆️
builder/azure/arm/config.go 82.80% <ø> (+0.21%) ⬆️
builder/azure/chroot/builder.go 51.75% <ø> (-1.07%) ⬇️
...r/azure/chroot/shared_image_gallery_destination.go 90.62% <ø> (-1.05%) ⬇️
builder/azure/common/client/config.go 60.46% <ø> (+7.25%) ⬆️
builder/azure/dtl/config.go 55.64% <ø> (-0.39%) ⬇️
builder/cloudstack/config.go 82.72% <ø> (+1.14%) ⬆️
... and 946 more

@azr
Copy link
Contributor Author

azr commented Apr 16, 2021

Mergin this now so that we get these changes before the plugin breakout. Makes our lives easier :D

@azr azr merged commit 87ba725 into master Apr 16, 2021
@azr azr deleted the azr_use_packer-sdc branch April 16, 2021 09:52
Copy link
Member

@sylviamoss sylviamoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@ghost
Copy link

ghost commented May 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators May 17, 2021
@SwampDragons SwampDragons added the tech-debt Issues and pull requests related to addressing technical debt or improving the codebase label May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change tech-debt Issues and pull requests related to addressing technical debt or improving the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants