fix source accessor to allow use in source block

[SwampDragons]

Makes sure that the source name and type are part of the eval context for builds; this allows you to use source.type and source.

Test func:

source "amazon-ebs" "cannonical-ubuntu-server" {
// ...
  run_volume_tags = {
    builder-type-hcl = source.type
    builder-name-hcl = source.name
  }
}

Before:

==> vanilla.amazon-ebs.cannonical-ubuntu-server: Adding tags to source instance
    vanilla.amazon-ebs.cannonical-ubuntu-server: Adding tag: "Name": "Packer Builder"
    vanilla.amazon-ebs.cannonical-ubuntu-server: Adding tag: "builder-name-hcl": "<unknown>"
    vanilla.amazon-ebs.cannonical-ubuntu-server: Adding tag: "builder-type-hcl": "<unknown>"

After:

==> vanilla.amazon-ebs.cannonical-ubuntu-server: Adding tags to source instance
    vanilla.amazon-ebs.cannonical-ubuntu-server: Adding tag: "Name": "Packer Builder"
    vanilla.amazon-ebs.cannonical-ubuntu-server: Adding tag: "builder-name-hcl": "cannonical-ubuntu-server"
    vanilla.amazon-ebs.cannonical-ubuntu-server: Adding tag: "builder-type-hcl": "amazon-ebs"

[azr]

LGTM, I would maybe add a test for this one, to avoid regressions :)

[sylviamoss]

👍🏼

[sylviamoss]

The following will give the same result and if in the future we add a new attribute we will have to change only in one place.

Suggested change

	ectx.Variables[sourcesAccessor] = cty.ObjectVal(map[string]cty.Value{
	"type": cty.StringVal(source.Type),
	"name": cty.StringVal(source.Name),
	})
	ectx.Variables[sourcesAccessor] = cty.ObjectVal(source.ctyValues())

The ctyValues is also used here

[SwampDragons]

This is cool! Thanks for sharing.

[nywilken]

Looks good to me. Also nice learning here on
ectx.Variables[sourcesAccessor] = cty.ObjectVal(source.ctyValues())

[SwampDragons]

Added tests -- I'll merge when green

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.