Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to use build variables in a post processor #11323

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Allow to use build variables in a post processor #11323

merged 2 commits into from
Oct 11, 2021

Conversation

azr
Copy link
Contributor

@azr azr commented Oct 11, 2021 •
edited
Loading

fix #11262

@azr azr requested a review from a team as a code owner October 11, 2021 12:32
nywilken
nywilken approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. LGTM

nywilken
nywilken approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

All test have been fixed on master. I confirmed locally with a small rebase so all good to merge.

@nywilken nywilken merged commit 254e020 into master Oct 11, 2021
@nywilken nywilken deleted the azr/build-var-in-pp branch October 11, 2021 14:17
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build variables not working in post-processor
2 participants
@azr @nywilken