Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show successful message upon successful packer validate #11337

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

rohitkothari
Copy link
Contributor

Display a successful message when packer validate does not find any invalid template(s) and configurations.

Test Results

(I ran into some issues running existing unit tests, therefore tested validate flows manually like below.)

Valid HCL template
Screen Shot 2021-10-16 at 8 42 45 PM

Invalid HCL template
Screen Shot 2021-10-16 at 8 43 20 PM

Valid JSON template
Screen Shot 2021-10-16 at 8 50 54 PM

Invalid JSON template
Screen Shot 2021-10-16 at 8 56 55 PM

All above templates with --syntax-only
Screen Shot 2021-10-16 at 8 59 26 PM

Closes #11321

@rohitkothari rohitkothari requested a review from a team as a code owner October 17, 2021 04:04
@hashicorp-cla
Copy link

hashicorp-cla commented Oct 17, 2021

CLA assistant check
All committers have signed the CLA.

command/validate.go Outdated Show resolved Hide resolved
@azr azr merged commit 6a569b9 into hashicorp:master Oct 18, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2021
@azr
Copy link
Contributor

azr commented Nov 18, 2021

Thanks for your time !

@rohitkothari rohitkothari deleted the validate-successful-msg branch December 4, 2021 03:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: make packer validate say something on a valid config
3 participants