Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File provisioner: don't fail when no content is passed. #11349

Merged
merged 1 commit into from
Oct 28, 2021
Merged

File provisioner: don't fail when no content is passed. #11349

merged 1 commit into from
Oct 28, 2021

Conversation

azr
Copy link
Contributor

@azr azr commented Oct 21, 2021 •
edited
Loading

Does that sound like a bad idea ?

fix #11346

@azr azr requested a review from a team as a code owner October 21, 2021 13:47
sylviamoss
sylviamoss approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@sylviamoss sylviamoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a problem with that 🤔
In this case, I suppose Packer won't upload/download anything, right?

nywilken
nywilken approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@nywilken nywilken left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe we can add a message to the ui indicating that it was a noop because of no source or content, if users get confused about the provisioner not generating a file in the future.

@nywilken nywilken merged commit 948ef1f into master Oct 28, 2021
@nywilken nywilken deleted the azr/file-prov-dont-fail-when-no-content branch October 28, 2021 19:50
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

@sylviamoss sylviamoss sylviamoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for an empty 'sources' list in 'file' provisioner
3 participants
@azr @nywilken @sylviamoss