Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HCL2: fix a crash when an HCL2 component is nil after a misconfiguration #11382

Merged
merged 5 commits into from
Nov 4, 2021
Merged

HCL2: fix a crash when an HCL2 component is nil after a misconfiguration #11382

merged 5 commits into from
Nov 4, 2021

Conversation

azr
Copy link
Contributor

@azr azr commented Nov 4, 2021 •
edited
Loading

fix #11381

@azr azr requested a review from a team as a code owner November 4, 2021 13:17
nywilken
nywilken approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nywilken nywilken merged commit 710d109 into master Nov 4, 2021
@nywilken nywilken deleted the azr/fix-crash-nil-component branch November 4, 2021 14:08
@github-actions
Copy link

github-actions bot commented Dec 5, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nywilken nywilken nywilken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when timeout lacks formater, e.g. "1h10" vs "1h10m"
2 participants
@azr @nywilken