Tiny tweaks and fixes for the PowerShell provisioner #11410
Conversation
| if os.IsPathSeparator(p.config.RemotePath[len(p.config.RemotePath)-1]) { | ||
| // path is a directory | ||
| p.config.RemotePath += filepath.Base((fi).Name()) | ||
| p.config.RemotePath += filepath.Base(fi.Name()) |
There was a problem hiding this comment.
os.IsPathSeparator on Windows will check for \ and / ! filepath.Base internally uses IsPathSeparator to find the base path, so it should be fine.
There was a problem hiding this comment.
Nice 👍 - thanks for the call out here.
| if os.IsPathSeparator(p.config.RemotePath[len(p.config.RemotePath)-1]) { | ||
| // path is a directory | ||
| p.config.RemotePath += filepath.Base((fi).Name()) | ||
| p.config.RemotePath += filepath.Base(fi.Name()) |
There was a problem hiding this comment.
Nice 👍 - thanks for the call out here.
| ~> On Windows, if possible, try to always use a backslash `\` as a path | ||
| separator, especially when dealing with non full paths. This is because when | ||
|
|
There was a problem hiding this comment.
The examples below use / and not \ should this suggestion be updated?
I think this rationale will be helpful "This is because when..."
| ~> On Windows, if possible, try to always use a backslash `\` as a path | |
| separator, especially when dealing with non full paths. This is because when | |
| ~> On Windows, if possible, try to always use a backslash `\` as the path | |
| separator, especially when dealing with relative paths. The use of backslashes helps with [....] | |
There was a problem hiding this comment.
Ha yes, good catch, this is a WIP commit I pushed before we switched over to the acc tests branch ! Fixing now.
There was a problem hiding this comment.
I made it clearer; and now wonder if we should display this in other places too. Ah, I will make a template out of this !
make it a note
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
fix #6188